MINOR: update truncation test #18952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
dajac
reviewed
Feb 19, 2025
| @@ -112,7 +117,10 @@ def none_consumed(this, consumer): | |||
|
|
|||
| pre_truncation_pos = consumer.current_position(tp) | |||
|
|
|||
| self.kafka.set_unclean_leader_election(self.TOPIC) | |||
There was a problem hiding this comment.
For my understanding, why can't we use this one any more?
There was a problem hiding this comment.
set_unclean_leader_election sets the unclean.leader.election.enable config to true. It is the same if we set this config when creating the topic.
Creating the topic with the config so that the unclean election can trigger by this event. In the old way, election happens here which is no longer possible if use wait_until to wait for the unclean leader election.
|
testBalancePartitionLeaders can pass in local. Can we rerun the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the minISR to be 1 for the truncation test in order to skip the protection from KIP-966