Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope #18972

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope #18972

wants to merge 3 commits into from

Conversation

mingdaoy
Copy link
Contributor

https://issues.apache.org/jira/browse/KAFKA-18834

./gradlew cleanTest connect:runtime:test --tests LoggersTest.testSetLevelWithValidRootLoggerNames --tests LoggingResourceTest.testSetLevelDefaultScope -PmaxParallelForks=1

image

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community connect tests Test fixes (including flaky tests) small Small PRs labels Feb 19, 2025
@mingdaoy
Copy link
Contributor Author

Hi maintainers, could you please approve this workflow when you have a chance? Thanks!

@mingdaoy mingdaoy changed the title KAFKA-18834 Fix testSetLevelWithValidRootLoggerNames for testSetLevel… KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope Feb 19, 2025
@chia7712
Copy link
Member

Personally, I prefer to adjust the level for the testSetLevelDefaultScope. Please see my comment on the jira

chia7712
chia7712 reviewed Feb 19, 2025
View reviewed changes
...ntime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResourceTest.java Outdated
@@ -113,7 +113,7 @@ public void setLevelWithInvalidArgTest() {

@Test
public void testSetLevelDefaultScope() {
testSetLevelWorkerScope(null, true);
testSetLevelWorkerScope("worker", false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I fail to catch this fix. Could you please share the detail to me?

@chia7712
Copy link
Member

Another way is to reset the log level in testSetLevelWithValidRootLoggerNames. It changes "all" loggers, so it may impact other tests too.

@github-actions github-actions bot removed the triage PRs from the community label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 left review comments

Assignees
No one assigned
Labels
ci-approved connect small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingdaoy @chia7712