KNOX-3075 - Handling unlimited token expiration in JDBC TSS properly #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @moresandeep, @pzampino - Can any of you please check this out for me? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As described in KNOX-3075, when the token TTL was set to -1 (which allows creating never-expiring tokens), JDBC TSS threw an
UnknownTokenException. This is wrong. It should have returned the configured-1value.How was this patch tested?
I updated existing JUnit tests to handle the path when fetching tokens for a user. I also added 2 new test cases to ensure this issue never occurs again.