persist cluster-enabled status in RocksDB #2020
Open
+91
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@git-hulk Please help review :) |
caipengbo
reviewed
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
|
@chrisxu333 Please, run |
chrisxu333
force-pushed
the
persist_cluster-enabled_option
branch
from
244f927
to
74f245b
Compare
git-hulk
reviewed
Jan 15, 2024
caipengbo
reviewed
Jan 15, 2024
chrisxu333
force-pushed
the
persist_cluster-enabled_option
branch
from
74f245b
to
f3b8266
Compare
PragmaTwice
reviewed
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
chrisxu333
force-pushed
the
persist_cluster-enabled_option
branch
from
f3151b9
to
034759b
Compare
PragmaTwice
reviewed
Jan 15, 2024
chrisxu333
force-pushed
the
persist_cluster-enabled_option
branch
from
034759b
to
f4d36b5
Compare
|
|
Hi @git-hulk could you also help diagnose why the newly introduced testcase is failed? It was successful when I did locally. |
perhaps you can try to debug the test case yourself, and I will also take a look while I'm free. |
PragmaTwice
reviewed
May 5, 2024
| @@ -152,6 +152,11 @@ Status Server::Start() { | |||
| } | |||
| } | |||
|
|
|||
| s = checkClusterMode(); | |||
There was a problem hiding this comment.
Seems this should be before the namespace_.LoadAndRewrite(). To avoid some weird error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #1410 .