Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add analytics script #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ayhamthemayhem
Copy link

Hey there,

This is part of our work at Neighbourhoodie/ with STF's Bug Resilience Program for Log4j.

This is a PR to add a script file that can be loaded into other logging websites to load matomo analytics scripts for website based on if they are dormant or active.

I used an example of a matomo script that we found here

Do you maybe have an example of what a matomo script for dormant websites looks like ?

@rgoers
Copy link
Member

rgoers commented Oct 23, 2024

Why would you skip dormant projects? At some point flume will be coming back into the fold and I won't want to remember to have to modify this.

@grobmeier It looks like you added a link to analytics.apache.org? What is that?

@ppkarwasz
Copy link
Contributor

@ayhamthemayhem,

Could you also remove Matomo from footer.html and add a reference to your script to header.html?

I don't think there should be a difference between dormant and active subproject. Maybe we could add some custom dimension, but I don't know what would make sense.
Certainly, for GDPR reasons we need to ask user for their consent to track them (see managing consent). That fact must have slipped our mind when we added Matomo. @grobmeier, am I right?

@rgoers,

analytics.apache.org contains an on premises installation of the Matomo tracking software. It should be useful to track the popularity of pages and also find out the 404 errors.

@ayhamthemayhem
Copy link
Author

ayhamthemayhem commented Oct 30, 2024

Why would you skip dormant projects? At some point flume will be coming back into the fold and I won't want to remember to have to modify this.

Hey, dormant projects are not skipped they just have a different script than others but that is also still unclear and up to discussing which projects go to which array but and that is up to the log4j team to decide.

@ayhamthemayhem
Copy link
Author

ayhamthemayhem commented Oct 30, 2024

Could you also remove Matomo from footer.html and add a reference to your script to header.html?

done !

@ayhamthemayhem
Copy link
Author

If there is a list or more info on which websites are dormant or skipped that would be great.
I would adjust the PR quickly as needed :)

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me,
but I would wait for a review of our V.P. Data Privacy (@grobmeier) before merging it. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants