Taxonomy counts are incorrect due to ordinal sorting (#14008) #14010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulk-asert
force-pushed
the
issue14008
branch
from
21db9f5
to
fd7f2d0
Compare
stefanvodita
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Thank you for the fix and the test @paulk-asert!
I think we should push this to main, 10x, and 9x. I'll leave it up for a little while and if no one objects I'll add a CHANGES section for 9.12.1 and mention this bug fix here and in 10.0.1.
|
At the same time, I don't think we need to rush bug fix releases, since this functionality was broken from the time it was released. |
stefanvodita
pushed a commit
that referenced
this pull request
Nov 23, 2024
stefanvodita
pushed a commit
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just moved collecting the counts to before the sort occurs. Added a test which currently fails but passes after the change.
Closes #14008