[MPLUGINTESTING-93] Documentation for Plugin testing #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bukama
reviewed
Dec 22, 2024
elharo
changed the title
elharo
reviewed
Dec 23, 2024
|
Thanks @slawekjaranowski @elharo and @Bukama for your review! I learned a lot and was able to address your review comments with (for me) sound solutions. |
elharo
requested changes
Jan 6, 2025
|
|
||
| ### Using PlexusTestCase | ||
|
|
||
| Mojo variables are injected by Guice (an open-source software framework for the Java platform), sometimes with a Codehaus Plexus (a collection of components used by Apache Maven) adapter to support the legacy `@Component` annotation. |
There was a problem hiding this comment.
delete "to support the legacy @Component annotation."
I've eliminated all of those
|
Can't add anything to what @elharo has already mentioned. |
elharo
reviewed
Jan 7, 2025
|
|
||
| ### Using PlexusTestCase | ||
|
|
||
| Mojo variables are injected by Guice (an open-source software framework for the Java platform), sometimes with a Codehaus Plexus (a collection of components used by Apache Maven) adapter. |
There was a problem hiding this comment.
delete "(an open-source software framework for the Java platform)" as it doesn't add much. Folks can Google it if they've never heard of it
There was a problem hiding this comment.
and might as wellm delete "(a collection of components used by Apache Maven)" too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Docu on how to test with JUnit5.
Converted the Docu from apt to md .
This PR should only get merged once org.apache.maven.plugin-testing:maven-plugin-testing-harness:3.4.0 has been released as on 3.3.0 there is no JUnit5 testing support at all.