This repository has been archived by the owner on May 12, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should focus on improving our CI builds to catch as many problems as possible and rely less on manual testing and due diligence.
One gap we have now is that if a change is submitted that breaks the RPMs, the CI build will not detect the problem. This kind of problem can only be detected by relying on our contributors and committers to dutifully run-up the development environment.
This change allows for the RPMs to be built as part of the Travis CI build. If the RPMs fail to build, the Travis CI build should fail.
Point to Consider for Reviewers
Building the RPMs requires a complete build of Metron. This will likely push our backs up against the 50 minute time window allowed by Travis. #1522 gave us some breathing room by shuffling what we build and when, but did not fundamentally solve that problem.
If this change risks causing numerous intermittent test failures due to timeouts, I'd prefer to hold this change until that problem can be addressed. I will confirm whether this is a problem and comment later on this PR.
Changes
This adds an additional step "Build RPMs" that builds the Metron RPMs in parallel with the other build and validation steps.
Testing
metron.spec
.See the following Travis builds.
Pull Request Checklist