Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBeans RELEASE240 JavaDoc Malformed #8128

Open
timothystone opened this issue Jan 9, 2025 · 7 comments
Open

NetBeans RELEASE240 JavaDoc Malformed #8128

timothystone opened this issue Jan 9, 2025 · 7 comments
Labels
build JavaDoc [ci] enable java/javadoc tests and build-javadoc target kind:bug Bug report or fix priority:critical Showstopper issue that requires fixing in next release Regression This used to work!
Milestone

Comments

@timothystone
Copy link

timothystone commented Jan 9, 2025

Apache NetBeans version

Apache NetBeans 24

What happened

In attempting to view JavaDoc in the development of a new .nbm project, none of it works.

The JavaDoc JARs are malformed. Comparing the contents of RELEASE230 and RELEASE240 JARs.

RELEASE240 (L) vs. RELEASE230 (R)

Language / Project Type / NetBeans Component

Java Maven NetBeans NBM project

How to reproduce

Download any RELEASE240 JavaDoc, e.g., *-RELEASE240-javadoc.jar. Compare and Contrast these JARs on Central:

org-netbeans-modules-projectapi-RELEASE230-javadoc.jar 410807 bytes

org-netbeans-modules-projectapi-RELEASE240-javadoc.jar 57410 bytes

Did this work correctly in an earlier version?

Apache NetBeans 23

Operating System

macOS 15.2 Apple Silicon M3 Max

JDK

OpenJDK Runtime Environment Temurin-23.0.1+11 (build 23.0.1+11)

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

I would submit a PR, but this is a maintainer build problem.

Are you willing to submit a pull request?

No

@timothystone timothystone added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Jan 9, 2025
@mbien mbien added build JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels Jan 9, 2025
@mbien mbien added this to the NB25 milestone Jan 9, 2025
@mbien mbien added Regression This used to work! and removed needs:triage Requires attention from one of the committers labels Jan 9, 2025
@neilcsmith-net
Copy link
Member

Thanks for the report @timothystone

Note that the current daily snapshots also seem to be OK - https://repository.apache.org/content/repositories/snapshots/org/netbeans/api/org-netbeans-modules-projectapi/dev-SNAPSHOT/

I would submit a PR, but this is a maintainer build problem.

Yes, although we're still not entirely sure what happened specifically with RELEASE240. I'll mark this critical for release, and it's one more thing for everyone to keep an eye on. Any input you can give to verify it's not recurring with NB25, and/or helping track the cause if it reappears, would of course be appreciated.

@neilcsmith-net neilcsmith-net added the priority:critical Showstopper issue that requires fixing in next release label Jan 9, 2025
@timothystone
Copy link
Author

Yes, although we're still not entirely sure what happened specifically with RELEASE240... Any input you can give to verify it's not recurring with NB25, and/or helping track the cause if it reappears, would of course be appreciated.

Of course! While I don't have the bandwidth for nightly build testing of the platform, I'll have NB 25 very shortly after the release.

I'm a NB user ... since way back, literally v3.x. (I got married in 2000 and was using NB in my consulting work that September I know because I was presenting to a Java cohort). Converted an enterprise practice to NB c. 2006 for the Maven support alone; let's never mention Eclipse Maven support in polite company). Today, NB is still my first IDE in personal work (less so in the office for all the reasons one must balance).

Thanks for looking out on the user list. I should have seen it, but I had tunnel vision on my first NBM in all these years and just learning the ropes left me open to a couple of misunderstandings.

@ebarboni
Copy link
Contributor

thanks for report, will hack the json file to allow dummy rc build on release 240 to see if it's reproductible

@mbien
Copy link
Member

mbien commented Jan 10, 2025

we should give out cookies for well written while still concise issue reports.

@ebarboni
Copy link
Contributor

the release240 use jdk17 to build and because of the change in template do disableindoc [javadoc] error: invalid flag: --disable-line-doc-comments error is triggered
the master build is using the jdk 23 so it works.

on releasexxx we use the lowest jdk because javadoc jar was not openable with jdk using lower version maybe it's possible to alter that.

@mbien
Copy link
Member

mbien commented Jan 10, 2025

the reason we used JDK 23 in the first place is due to issues with nb-javac since it is based on the most recent JDK INFRA-26219.

NB is full with instances of /// which were never intended to be javadoc. So we had to add the line-doc switch last minute #7907.

(I even mention on the PR that everything is using JDK 23 now for javadoc so the flag should not be a problem ;))

So i am a bit confused why one branch has to use 23 but the other 17?

@ebarboni
Copy link
Contributor

on releasexxx if we build the javadoc jar using latest jdk it was not possible to open it using the baseline jdk. maybe it's not the case anymore so we could build it like we do master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build JavaDoc [ci] enable java/javadoc tests and build-javadoc target kind:bug Bug report or fix priority:critical Showstopper issue that requires fixing in next release Regression This used to work!
Projects
None yet
Development

No branches or pull requests

4 participants