Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set javadoc 23 specific flags only on JDK 23 and later #8152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 14, 2025

followup to #7907

  • it turned out that release branches build docs using JDK 17 still
  • flag is now set on JDK23+ only, in both javadoc-exec-files and javadoc-exec-packages (first was overlook last time)

might help with #8128 (not sure if it fixes it, would need verification)

@mbien mbien added the JavaDoc [ci] enable java/javadoc tests and build-javadoc target label Jan 14, 2025
@mbien mbien force-pushed the set-line-doc-flag-only-on-23 branch from b9e9891 to 1cc1873 Compare January 14, 2025 16:19
@mbien mbien force-pushed the set-line-doc-flag-only-on-23 branch from 1cc1873 to 2aa0bb4 Compare January 14, 2025 16:39
@mbien mbien added the build label Jan 14, 2025
@mbien mbien added this to the NB25 milestone Jan 14, 2025
@ebarboni
Copy link
Contributor

release build is fixed to build on what json tell but anyone could build with jdk 17 and not be aware to use different jdk for apidoc,
So good change IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build JavaDoc [ci] enable java/javadoc tests and build-javadoc target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants