MINIFICPP-2117 Fix bustache build in C++20 mode #1617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaszm
reviewed
Jul 26, 2023
lordgamez
approved these changes
Jul 27, 2023
szaszm
reviewed
Jul 27, 2023
This comment was marked as outdated.
This comment was marked as outdated.
martinzink
force-pushed
the
MINIFICPP-2117
branch
from
7ae6635
to
abf83ef
Compare
martinzink
force-pushed
the
MINIFICPP-2117
branch
from
abf83ef
to
af17b69
Compare
szaszm
reviewed
Aug 18, 2023
Co-authored-by: Márton Szász <[email protected]>
martinzink
force-pushed
the
MINIFICPP-2117
branch
from
a4dbcd8
to
d1f674b
Compare
adamdebreceni
approved these changes
Aug 28, 2023
szaszm
approved these changes
Aug 30, 2023
fgerlits
reviewed
Aug 30, 2023
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| #include <memory> | |||
|
|
|||
| using HANDLE = void*; | |||
There was a problem hiding this comment.
could we include some Windows header instead of this?
|
Do we know why the MQTT docker test failed? Is it definitely unrelated to this PR? |
There have been various MQTT test failures lately, there is an open jira ticket for it: https://issues.apache.org/jira/browse/MINIFICPP-2195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.