-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2170 Fix system certificate store usage in SSLContextService on Linux #1620
MINIFICPP-2170 Fix system certificate store usage in SSLContextService on Linux #1620
Conversation
9bd574b
to
d707744
Compare
9d2cb5c
to
784bb18
Compare
Could we document the |
I was planning to do that, but it would take quite a bit of additional code to create automatic tests for this, as it requires that none of the files listed in I don't think we want to encourage people to use the I have tested these manually because in case there is a production issue we need a quick temporary solution for, it's good to know we have this option. |
83edabe
to
d0c45f4
Compare
…e on Linux Use utils::getDefaultCAFile() in the SSLContextService to find the system CA certificate store file, as the compiled-in default value is usually wrong. If the system CA certificate store file is still not found, you can set the SSL_CERT_DIR or SSL_CERT_FILE environment variables to tell OpenSSL where the certificates are. Also: fix the incorrect handling of InvokeHTTP::DisablePeerVerification.
... because /etc/ssl/certs is used by kind internally
d0c45f4
to
a6efd56
Compare
https://issues.apache.org/jira/browse/MINIFICPP-2170
Use
utils::getDefaultCAFile()
in theSSLContextService
to find the system CA certificate store file, as the compiled-in default value is usually wrong. If the system CA certificate store file is still not found, you can set theSSL_CERT_DIR
orSSL_CERT_FILE
environment variables to tell OpenSSL where the certificates are.Also: fix the incorrect handling of
InvokeHTTP::DisablePeerVerification
.Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.