Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2146 Add support for SMB networking protocol #1634

Closed
wants to merge 25 commits into from

Conversation

martinzink
Copy link
Member

@martinzink martinzink commented Aug 18, 2023

This includes these processors:
MINIFICPP-2147 PutSmb based loosely on NiFi's PutSmb
MINIFICPP-2148 FetchSmb based loosely on NiFi's FetchSmb
MINIFICPP-2150 ListSmb based loosely on NiFi's ListSmb

I've left out GetSmb processor because that functionality can be easily achived by a GenerateFlowFile+FetchSmb flow.

There are a lot of similarities between the Put/Fetch/List-Smb and Put/Fetch/List-File processors. However, the interface, as well as the output attributes, are different enough that I didn't want to create a tight coupling between them. Therefore, I only extracted out the common methods into various helper classes and functions.

I've also included a couple QoL changes I've come across while working on windows. (e.g. stringToWideString, warning fixex, etc)


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink marked this pull request as ready for review August 18, 2023 18:24
Copy link
Member

@szaszm szaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm about 1/3 of the way through

libminifi/src/utils/file/FileUtils.cpp Outdated Show resolved Hide resolved
libminifi/src/utils/file/FileUtils.cpp Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
libminifi/src/utils/file/FileUtils.cpp Show resolved Hide resolved
cmake/MiNiFiOptions.cmake Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
extensions/smb/SmbConnectionControllerService.cpp Outdated Show resolved Hide resolved
extensions/smb/SmbConnectionControllerService.cpp Outdated Show resolved Hide resolved
extensions/smb/tests/ListSmbTests.cpp Show resolved Hide resolved
run_clang_tidy.sh Show resolved Hide resolved
extensions/standard-processors/processors/PutFile.h Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.h Outdated Show resolved Hide resolved
extensions/smb/SmbConnectionControllerService.cpp Outdated Show resolved Hide resolved
extensions/smb/ListSmb.h Outdated Show resolved Hide resolved
extensions/smb/ListSmb.h Outdated Show resolved Hide resolved
extensions/smb/ListSmb.h Show resolved Hide resolved
extensions/smb/SmbConnectionControllerService.cpp Outdated Show resolved Hide resolved
extensions/smb/SmbConnectionControllerService.cpp Outdated Show resolved Hide resolved
extensions/smb/SmbConnectionControllerService.cpp Outdated Show resolved Hide resolved
extensions/smb/tests/FetchSmbTests.cpp Outdated Show resolved Hide resolved
libminifi/src/core/logging/Logger.cpp Show resolved Hide resolved
extensions/smb/tests/ListSmbTests.cpp Outdated Show resolved Hide resolved
extensions/smb/tests/ListSmbTests.cpp Outdated Show resolved Hide resolved
extensions/smb/tests/utils/TempSmbShare.h Outdated Show resolved Hide resolved
libminifi/include/utils/file/FileUtils.h Outdated Show resolved Hide resolved
libminifi/include/utils/file/ListedFile.h Show resolved Hide resolved
libminifi/src/utils/OsUtils.cpp Outdated Show resolved Hide resolved
libminifi/src/utils/OsUtils.cpp Outdated Show resolved Hide resolved
libminifi/src/utils/OsUtils.cpp Outdated Show resolved Hide resolved
cmake/MiNiFiOptions.cmake Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
extensions/smb/FetchSmb.cpp Outdated Show resolved Hide resolved
libminifi/include/utils/file/FileUtils.h Outdated Show resolved Hide resolved
extensions/smb/PutSmb.cpp Show resolved Hide resolved
@martinzink martinzink force-pushed the MINIFICPP-2146 branch 2 times, most recently from 67706f0 to 4fe842c Compare September 14, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants