-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2146 Add support for SMB networking protocol #1634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaszm
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm about 1/3 of the way through
lordgamez
reviewed
Aug 24, 2023
martinzink
force-pushed
the
MINIFICPP-2146
branch
from
August 24, 2023 13:26
fb5dbbd
to
4f46a37
Compare
lordgamez
approved these changes
Aug 28, 2023
8 tasks
fgerlits
reviewed
Aug 31, 2023
fgerlits
reviewed
Sep 6, 2023
extensions/smb/tests/utils/MockSmbConnectionControllerService.h
Outdated
Show resolved
Hide resolved
martinzink
force-pushed
the
MINIFICPP-2146
branch
from
September 8, 2023 16:34
5e60ed3
to
dc160cf
Compare
szaszm
reviewed
Sep 12, 2023
adamdebreceni
approved these changes
Sep 12, 2023
martinzink
force-pushed
the
MINIFICPP-2146
branch
2 times, most recently
from
September 14, 2023 08:12
67706f0
to
4fe842c
Compare
fgerlits
approved these changes
Sep 14, 2023
fgerlits
reviewed
Sep 19, 2023
szaszm
reviewed
Sep 20, 2023
szaszm
approved these changes
Sep 21, 2023
MINIFICPP-2147 PutSmb MINIFICPP-2148 FetchSmb MINIFICPP-2150 ListSmb
Co-authored-by: Márton Szász <[email protected]>
This reverts commit 09c396a.
martinzink
force-pushed
the
MINIFICPP-2146
branch
from
September 21, 2023 08:17
40dff80
to
8c19ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes these processors:
MINIFICPP-2147 PutSmb based loosely on NiFi's PutSmb
MINIFICPP-2148 FetchSmb based loosely on NiFi's FetchSmb
MINIFICPP-2150 ListSmb based loosely on NiFi's ListSmb
I've left out GetSmb processor because that functionality can be easily achived by a GenerateFlowFile+FetchSmb flow.
There are a lot of similarities between the Put/Fetch/List-Smb and Put/Fetch/List-File processors. However, the interface, as well as the output attributes, are different enough that I didn't want to create a tight coupling between them. Therefore, I only extracted out the common methods into various helper classes and functions.
I've also included a couple QoL changes I've come across while working on windows. (e.g. stringToWideString, warning fixex, etc)
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.