MINFICPP-2243 - In ListenHTTP process incoming request only in onTrigger #1826
+370
−357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdebreceni
force-pushed
the
MINIFICPP-2243
branch
from
52d14ea
to
4e91dbe
Compare
martinzink
approved these changes
Sep 9, 2024
szaszm
reviewed
Oct 2, 2024
adamdebreceni
force-pushed
the
MINIFICPP-2243
branch
from
89d9d1a
to
f5af871
Compare
szaszm
reviewed
Oct 16, 2024
szaszm
reviewed
Oct 21, 2024
Comment on lines
+170
to
+178
| struct RequestValue { | ||
| std::reference_wrapper<core::ProcessSession> session; | ||
| std::promise<void> ret; | ||
| }; | ||
| struct FailureValue { | ||
| FailureReason reason; | ||
| std::promise<void> ret; | ||
| }; | ||
| using Request = std::promise<nonstd::expected<RequestValue, FailureValue>>; |
There was a problem hiding this comment.
Why do we have promise in promise here?
There was a problem hiding this comment.
the processor should release all references to the ProcessSession before returning from onTrigger, and since writing the data into the flowfile happens on the Handler's thread, it is not enough for the Handler to wait for the onTrigger's resources (promise1) onTrigger should also wait for the Handler's thread to release these resources (promise2)
|
There are compilation errors in the CI It was caused by my suggestions, I didn't handle all references |
adamdebreceni
force-pushed
the
MINIFICPP-2243
branch
2 times, most recently
from
85adf35
to
2667658
Compare
Co-authored-by: Márton Szász <[email protected]>
Co-authored-by: Márton Szász <[email protected]>
adamdebreceni
force-pushed
the
MINIFICPP-2243
branch
from
2667658
to
116e244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.