Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2462 - Divide libminifi #1870

Closed
wants to merge 21 commits into from

Conversation

adamdebreceni
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@james94
Copy link
Contributor

james94 commented Oct 1, 2024

Is there a Jira ticket associated with this PR effort? This seems like a huge refactoring contribution.

@adamdebreceni adamdebreceni marked this pull request as ready for review October 15, 2024 13:22
@szaszm
Copy link
Member

szaszm commented Nov 25, 2024

  • rename /core to /minifi-api, /minifi-api/include is in the include path, e.g. #include "minifi-cpp/core/FlowFile.h"
  • ProcessCpuUsageTracker, Cron shouldn't be in extension-utils

@adamdebreceni
Copy link
Contributor Author

Closing this in favor of #1902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants