MINIFICPP-2484 Find and load libpython automatically #1889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
force-pushed
the
MINIFICPP-2484
branch
from
2d8fbe6
to
55f5ae2
Compare
szaszm
reviewed
Nov 4, 2024
martinzink
reviewed
Nov 5, 2024
martinzink
reviewed
Nov 7, 2024
lordgamez
force-pushed
the
MINIFICPP-2484
branch
from
ab2bb5f
to
4643419
Compare
lordgamez
force-pushed
the
MINIFICPP-2484
branch
from
4643419
to
6e532e9
Compare
martinzink
approved these changes
Nov 15, 2024
adamdebreceni
approved these changes
Nov 20, 2024
szaszm
reviewed
Nov 21, 2024
extensions/python/CMakeLists.txt
Outdated
| @@ -81,5 +89,8 @@ else() | |||
| ) | |||
| endif() | |||
|
|
|||
| if (NOT WIN32 AND NOT APPLE) | |||
| register_extension(minifi-python-lib-loader-extension "PYTHON LIB LOADER" PYTHON-LIB-LOADER-EXTENSIONS "This enables library that loads python library for python symbols") | |||
There was a problem hiding this comment.
I'd keep things singular. Plural naming is individual extensions is a bad pattern IMO.
Suggested change
| register_extension(minifi-python-lib-loader-extension "PYTHON LIB LOADER" PYTHON-LIB-LOADER-EXTENSIONS "This enables library that loads python library for python symbols") | |
| register_extension(minifi-python-lib-loader-extension "PYTHON LIB LOADER" PYTHON-LIB-LOADER-EXTENSION "This enables library that loads python library for python symbols") |
There was a problem hiding this comment.
Updated in 5b7ce99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2484
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.