-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mtetest: Add a series of tests for the mte instruction set #2875
Open
W-M-R
wants to merge
1
commit into
apache:master
Choose a base branch
from
W-M-R:mte
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+456
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Experimental Bot, please feedback here] This PR appears to mostly meet the NuttX requirements, but is missing some key information. Here's a breakdown: Strengths:
Weaknesses:
Recommendations for Improvement:
By addressing these points, the PR will be significantly improved and easier for reviewers to evaluate. |
Added basic mte instructions, ldg, stg, irg, gmi instruction tests ➜ NX git:(master) ✗ qemu-system-aarch64 -cpu max -nographic \ -machine virt,virtualization=on,gic-version=3,mte=on \ -chardev stdio,id=con,mux=on, -serial chardev:con \ -mon chardev=con,mode=readline -kernel ./nuttx/nuttx - Ready to Boot Primary CPU - Boot from EL2 - Boot from EL1 - Boot to C runtime for OS Initialize NuttShell (NSH) nsh> nsh> nsh> mtetest Spawning process for test: mtetest1 Running test: mtetest1 Test 'mtetest1' completed Spawning process for test: mtetest2 Running test: mtetest2 Test 'mtetest2' completed Spawning process for test: mtetest3 Running test: mtetest3 Test 'mtetest3' completed Spawning process for test: mtetest4 Running test: mtetest4 Test 'mtetest4' completed Spawning process for test: mtetest5 Running test: mtetest5 Test 'mtetest5' completed All tests completed. nsh> Signed-off-by: wangmingrong1 <[email protected]>
xiaoxiang781216
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added basic mte instructions, ldg, stg, irg, gmi instruction tests
➜ NX git:(master) ✗ qemu-system-aarch64 -cpu max -nographic
-machine virt,virtualization=on,gic-version=3,mte=on
-chardev stdio,id=con,mux=on, -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx/nuttx
NuttShell (NSH)
nsh>
nsh>
nsh> mtetest
Spawning process for test: mtetest1
Running test: mtetest1
Test 'mtetest1' completed
Spawning process for test: mtetest2
Running test: mtetest2
Test 'mtetest2' completed
Spawning process for test: mtetest3
Running test: mtetest3
Test 'mtetest3' completed
Spawning process for test: mtetest4
Running test: mtetest4
Test 'mtetest4' completed
Spawning process for test: mtetest5
Running test: mtetest5
Test 'mtetest5' completed
All tests completed.
nsh>
Impact
Depends on apache/nuttx#14978
Testing