-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs/littlefs: Add a kconfig to override littlefs version #14903
Conversation
Hopefully, It's more user-friendly than the current method, which is just an overridable make variable. It would also help to make some features (and their associated local patches) conditional on littlefs version in future. Also, update CMakeLists.txt to use the same littlefs version as Makefile.
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in several sections. Here's a breakdown of the missing information: Summary:
Impact:
Testing:
In short, the PR needs significantly more detail and concrete information to meet the NuttX requirements. Focus on clarity, specificity, and providing evidence of testing. |
msys2 job failure looks unrelated
|
This also is unrelated
|
Note that $(CONFIG_FS_LITTLEFS_VERSION).tar.gz is expanded to eg. "v2.5.1".tar.gz. The extra quotes break make's file existence checks. Fixes: apache#15148 The regression was caused by apache#14903
Note that $(CONFIG_FS_LITTLEFS_VERSION).tar.gz is expanded to eg. "v2.5.1".tar.gz. The extra quotes break make's file existence checks. Fixes: apache#15148 The regression was caused by apache#14903
Note that $(CONFIG_FS_LITTLEFS_VERSION).tar.gz is expanded to eg. "v2.5.1".tar.gz. The extra quotes break make's file existence checks. Fixes: apache#15148 The regression was caused by apache#14903
Summary
Hopefully, It's more user-friendly than the current method, which is just an overridable make variable. It would also help to make some features (and their associated local patches) conditional on littlefs version in future.
Also, update CMakeLists.txt to use the same littlefs version as Makefile.
Impact
this changes littlefs version for cmake users.
Testing
esp32s3-devkit:toywasm