Fixed: Improvement of the Check xml tag (OFBIZ-12821)

Fixes a NPE bug reported by Michael Thanks: Michael Brohl
apache · Feb 3, 2025 · 7d7448e · 7d7448e
1 parent 64214ce
commit 7d7448e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
@@ -296,10 +296,13 @@ public void renderCheckField(Appendable writer, Map<String, Object> context, Che
         StringBuilder items = new StringBuilder();
         String checkBox = checkField.getModelFormField().getAttributeName();
         List<String> checkedByDefault = new ArrayList<String>();
-        if (context.containsKey(checkBox) && !context.get(checkBox).getClass().equals(String.class)) {
+
+        if (context.containsKey(checkBox) && context.get(checkBox) != null
+                && !context.get(checkBox).getClass().equals(String.class)) {
             checkedByDefault = context.containsKey(checkBox) ? StringUtil.toList(context.get(checkBox).toString())
                     : List.of();
         }
+
         if (UtilValidate.isNotEmpty(modelFormField.getWidgetStyle())) {
             className = modelFormField.getWidgetStyle();
             if (modelFormField.shouldBeRed(context)) {