ORC-1743: Upgrade Spark to 4.0.0-preview1 #1909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
commented
Apr 24, 2024
java/bench/spark/pom.xml
Outdated
| <exclude>META-INF/DUMMY.DSA</exclude> | ||
| <exclude>META-INF/*.SF</exclude> | ||
| <exclude>META-INF/*.DSA</exclude> | ||
| <exclude>META-INF/*.RSA</exclude> |
There was a problem hiding this comment.
[WARNING] eclipse-collections-11.1.0.jar, eclipse-collections-api-11.1.0.jar define 4 overlapping resources:
[WARNING] - LICENSE-EDL-1.0.txt
[WARNING] - LICENSE-EPL-1.0.txt
[WARNING] - META-INF/ECLIPSE_.RSA
[WARNING] - META-INF/ECLIPSE_.SF
There was a problem hiding this comment.
Currently, Spark has fixed this problem by upgrading the arrow-vector version, so there is no modification here.
[SPARK-47981][BUILD] Upgrade Arrow to 16.0.0
| @@ -74,7 +74,7 @@ | |||
| @BenchmarkMode(Mode.AverageTime) | |||
| @OutputTimeUnit(TimeUnit.MICROSECONDS) | |||
| @AutoService(OrcBenchmark.class) | |||
| @Fork(jvmArgsAppend = "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED") | |||
| @Fork(jvmArgsAppend = {"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED", "--add-opens=java.base/sun.util.calendar=ALL-UNNAMED"}) | |||
There was a problem hiding this comment.
Caused by: java.lang.IllegalAccessException: symbolic reference class is not accessible: class sun.util.calendar.ZoneInfo, from interface org.apache.spark.sql.catalyst.util.SparkDateTimeUtils (unnamed module @2b71fc7e)
at java.base/java.lang.invoke.MemberName.makeAccessException(MemberName.java:955)
at java.base/java.lang.invoke.MethodHandles$Lookup.checkSymbolicClass(MethodHandles.java:3686)
at java.base/java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:3646)
at java.base/java.lang.invoke.MethodHandles$Lookup.findVirtual(MethodHandles.java:2680)
at org.apache.spark.sql.catalyst.util.SparkDateTimeUtils.$init$(SparkDateTimeUtils.scala:206)
at org.apache.spark.sql.catalyst.util.DateTimeUtils$.<clinit>(DateTimeUtils.scala:41)
java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java
Outdated
Show resolved
Hide resolved
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 25, 2024
…mark ### What changes were proposed in this pull request? This PR aims to migrate to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark. ### Why are the changes needed? #1909 (review) ### How was this patch tested? local test ```bash java -jar spark/target/orc-benchmarks-spark-2.1.0-SNAPSHOT.jar spark data -format=parquet -compress zstd -data taxi ``` ``` Benchmark (compression) (dataset) (format) Mode Cnt Score Error Units SparkBenchmark.partialRead zstd taxi parquet avgt 5 17211.731 ± 11836.315 us/op SparkBenchmark.partialRead:bytesPerRecord zstd taxi parquet avgt 5 0.002 # SparkBenchmark.partialRead:ops zstd taxi parquet avgt 5 10.000 # SparkBenchmark.partialRead:perRecord zstd taxi parquet avgt 5 0.001 ± 0.001 us/op SparkBenchmark.partialRead:records zstd taxi parquet avgt 5 113791180.000 # ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes #1912 from cxzl25/ORC-1704. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 25, 2024
…mark ### What changes were proposed in this pull request? This PR aims to migrate to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark. ### Why are the changes needed? #1909 (review) ### How was this patch tested? local test ```bash java -jar spark/target/orc-benchmarks-spark-2.1.0-SNAPSHOT.jar spark data -format=parquet -compress zstd -data taxi ``` ``` Benchmark (compression) (dataset) (format) Mode Cnt Score Error Units SparkBenchmark.partialRead zstd taxi parquet avgt 5 17211.731 ± 11836.315 us/op SparkBenchmark.partialRead:bytesPerRecord zstd taxi parquet avgt 5 0.002 # SparkBenchmark.partialRead:ops zstd taxi parquet avgt 5 10.000 # SparkBenchmark.partialRead:perRecord zstd taxi parquet avgt 5 0.001 ± 0.001 us/op SparkBenchmark.partialRead:records zstd taxi parquet avgt 5 113791180.000 # ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes #1912 from cxzl25/ORC-1704. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit dc634cb) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Hi, @cxzl25 . Sorry for asking this, but could you rebase this PR once more? |
|
Thank you! |
java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java
Outdated
Show resolved
Hide resolved
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 1, 2024
…nchmark runs on JDK17 ### What changes were proposed in this pull request? This PR aims to fix `sun.util.calendar` IllegalAccessException when SparkBenchmark runs on JDK17. ### Why are the changes needed? #1909 (comment) ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? No Closes #1919 from cxzl25/ORC-1707. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 1, 2024
…nchmark runs on JDK17 ### What changes were proposed in this pull request? This PR aims to fix `sun.util.calendar` IllegalAccessException when SparkBenchmark runs on JDK17. ### Why are the changes needed? #1909 (comment) ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? No Closes #1919 from cxzl25/ORC-1707. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 5bb2346) Signed-off-by: Dongjoon Hyun <[email protected]>
|
If there is no further issue, shall we finalize this PR and merge with |
cxzl25
changed the title
I did some validation testing locally and I think the PR is ready to be merged. |
|
Thank you! |
dongjoon-hyun
approved these changes
Jul 12, 2024
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 12, 2024
### What changes were proposed in this pull request? This PR aims to upgrade the benchmark module to use Spark 4.0.0-preview1. ### Why are the changes needed? ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? No Closes #1909 from cxzl25/support_spark_4. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit bcb25fa) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade the benchmark module to use Spark 4.0.0-preview1.
Why are the changes needed?
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No