ORC-1730: [C++] Add finishEncode support for the encoder #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffacs
reviewed
Jun 13, 2024
c++/src/ByteRLE.cc
Outdated
| @@ -63,6 +63,11 @@ namespace orc { | |||
|
|
|||
| virtual void suppress() override; | |||
|
|
|||
| /** | |||
| * Finish encoding the stream. | |||
There was a problem hiding this comment.
The statement is a little bit confusing.
There was a problem hiding this comment.
More comments are added to finishEncode function.
c++/src/RLEv1.cc
Outdated
There was a problem hiding this comment.
We can rewrite RleEncoderV1::flush() with finishEncode() to make it clearer.
There was a problem hiding this comment.
Completed the refactoring of RleEncoderV1::flush().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add finishEncode() to the RLE encoder and implement finishStream() in BufferedOutputStream / compressionStream.
Why are the changes needed?
We expect to finish encoding when the compression block is aligned with the row group boundary.
How was this patch tested?
Uts in testRleEncode() can cover this patch.
Was this patch authored or co-authored using generative AI tooling?
No