Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tweak withAttributes in Flow #1658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 31, 2024

Motivation:

To avoid #1525 , I checked all the Flow#withAttributes usage.

Modification:
Move the .withAttributes() inside the via(...)

Result:

  1. consistent style
  2. safer when using it with graphdsl.

@He-Pin He-Pin added the t:stream Pekko Streams label Dec 31, 2024
@He-Pin He-Pin added this to the 1.2.0 milestone Dec 31, 2024
@pjfanning pjfanning changed the title chore: Tweak withAttribuets in Flow chore: Tweak withAttributes in Flow Dec 31, 2024
@pjfanning pjfanning modified the milestones: 1.2.0-M1, 1.2.0-M2 Jan 24, 2025
@He-Pin He-Pin modified the milestones: 1.2.0-M2, 1.2.0-M1 Jan 25, 2025
@He-Pin He-Pin added the bug Something isn't working label Jan 25, 2025
@He-Pin
Copy link
Member Author

He-Pin commented Jan 25, 2025

@pjfanning I think we should have this in 1.2.0-M1 , it's some kind of bug fix.

@pjfanning
Copy link
Contributor

@He-Pin
Copy link
Member Author

He-Pin commented Jan 25, 2025

Feel free to add it to m2, but actually the current fix not harm even without test.

Otherwise ,it will cause problem when using in graphdsl as the zipwithIndex was implemented.

@pjfanning
Copy link
Contributor

I am uncomfortable with adding this in M1. There will be an M2 in a month or 2 and hopefully this can be added with some tests.

@pjfanning pjfanning modified the milestones: 1.2.0-M1, 1.2.0-M2 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working t:stream Pekko Streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants