Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump golang.org/x/net from 0.0.0-20220225172249-27dd8689420f to 0.17.0 #1101

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2023

Bumps golang.org/x/net from 0.0.0-20220225172249-27dd8689420f to 0.17.0.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20220225172249-27dd8689420f to 0.17.0.
- [Commits](https://github.com/golang/net/commits/v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 11, 2023
@BewareMyPower
Copy link
Contributor

Error: /pkg/mod/golang.org/x/[email protected]/unix/mremap.go:42:10: undefined: unsafe.Slice

It seems we need to fix this error?

@liangyepianzhou
Copy link
Contributor

The errors are coming from the golang.org/x/sys package. They indicate that the unsafe.Slice function is not defined. This function was introduced in Go 1.17 to convert a *[N]T into a []T without creating a new slice.
@BewareMyPower @RobertIndie @shibd Could we upgrade the Go version to 1.17 or later.

@BewareMyPower
Copy link
Contributor

I don't know well about how Golang maintains its major releases. From here we can see the latest release of 1.16.x is go1.16.15 (released 2022-03-03). I'm not sure if there is an EOL for a Golang major release. But I'm okay to drop the Go 1.16 support.

It's better to open a discussion in the mail list for the context.

@BewareMyPower
Copy link
Contributor

Oh I just saw the release policy from https://go.dev/doc/devel/release#policy:

Each major Go release is supported until there are two newer major releases

i.e. we only need to support the three latest Golang major releases, e.g. 1.19, 1.20, 1.21 at the moment. So it's okay. But still, please open a discussion in the ML.

@liangyepianzhou
Copy link
Contributor

But still, please open a discussion in the ML.

@BewareMyPower Do you mind doing this? I noticed the author of this PR is a bot.

@BewareMyPower
Copy link
Contributor

Okay.

@BewareMyPower
Copy link
Contributor

I pushed a PR directly: #1155

So close this PR opened by bot

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 12, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/golang.org/x/net-0.17.0 branch January 12, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants