Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR-1071-5] refactor internalSend #1114

Closed
wants to merge 1 commit into from

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Oct 24, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #1071

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #1071

Motivation

Spilt PR #1071 into multiple ones, this is the FIFTH one.

#1071 is a BIG PR, it refactor the sending logic, here we just refactor internalSend(), send the message out.

As described in #1071, we need to apply the semaphore and memeory, get the schema meta, encoding and compress before we put the sendRequest into p.dataChan, or it will lead to inaccurate chunk count and wrong memory limit controlling, and we have move these logic into internalSendAsync().

And here in internalSend(), we just check if the message should send in batch or not, single chunk or multi chunks, send it accordingly.

Here we use the Defensive Programming manner to refactor the func, to reduce code indentation, to make the code looks more cleaner(too many if/else in the original code).

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@gunli
Copy link
Contributor Author

gunli commented Oct 24, 2023

@gunli gunli marked this pull request as draft October 24, 2023 05:45
@tisonkun
Copy link
Member

CI not pass. Closed. I'll try to take it over.

@tisonkun tisonkun closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants