[PR-1071-5] refactor internalSend #1114
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #1071
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #1071
Motivation
Spilt PR #1071 into multiple ones, this is the FIFTH one.
#1071 is a BIG PR, it refactor the sending logic, here we just refactor
internalSend()
, send the message out.As described in #1071, we need to apply the semaphore and memeory, get the schema meta, encoding and compress before we put the
sendRequest
intop.dataChan
, or it will lead to inaccurate chunk count and wrong memory limit controlling, and we have move these logic intointernalSendAsync()
.And here in
internalSend()
, we just check if the message should send in batch or not, single chunk or multi chunks, send it accordingly.Here we use the
Defensive Programming
manner to refactor the func, to reduce code indentation, to make the code looks more cleaner(too many if/else in the original code).Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation