Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: factor out validateMsg #1117

Merged
merged 1 commit into from
Oct 24, 2023
Merged

refactor: factor out validateMsg #1117

merged 1 commit into from
Oct 24, 2023

Conversation

tisonkun
Copy link
Member

This refers to #1071.

The main object is to move schema validation and codec to internalSendAsnc from internalSend. This is a self-contained step for validateMsg.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@tisonkun
Copy link
Member Author

cc @nodece @gunli

nodece
nodece approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun merged commit af56e60 into apache:master Oct 24, 2023
6 checks passed
@tisonkun tisonkun deleted the move-schema-encoding branch October 24, 2023 13:27
@tisonkun tisonkun mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece nodece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisonkun @nodece