Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transaction] Avoid a panic when using transaction #1144

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

Gilthoniel
Copy link
Contributor

@Gilthoniel Gilthoniel commented Dec 16, 2023

Motivation

When aborting or committing a transaction, it can happen that an error returned from the client triggers a panic when attempting to cast it to a Pulsar error.

Modifications

A proper check is performed when casting the error.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

This avoids a panic when the error returned by the client is not a
Pulsar error.
@RobertIndie RobertIndie added this to the v0.12.0 milestone Dec 19, 2023
@RobertIndie RobertIndie merged commit 062fefe into apache:master Dec 19, 2023
6 checks passed
@Gilthoniel Gilthoniel deleted the bugfix/tx-panic branch December 19, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants