Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Return an error when AckCumulative on a Shared/KeyShared subscription #1217

Merged
merged 1 commit into from
May 14, 2024

Conversation

RobertIndie
Copy link
Member

Motivation

The consumer should return error when AckCumulative on a Shared/KeyShared subscription

Verifying this change

This change added tests

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie self-assigned this May 14, 2024
@RobertIndie RobertIndie added this to the v0.13.0 milestone May 14, 2024
@RobertIndie RobertIndie merged commit 8e90873 into apache:master May 14, 2024
8 checks passed
@RobertIndie RobertIndie deleted the ack-error branch May 14, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants