[Improve] PIP-313 Support force unsubscribe using consumer api #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pulsar/consumer_test.go
crossoverJie
commented
May 16, 2024
| if state := pc.getConsumerState(); state == consumerClosed || state == consumerClosing { | ||
| pc.log.WithField("state", state).Error("Failed to unsubscribe closing or closed consumer") | ||
| return nil | ||
| return errors.New("consumer state is closed") |
There was a problem hiding this comment.
|
@RobertIndie PTAL, thanks. |
RobertIndie
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To keep consistent with the Java client.
Releted PR: apache/pulsar#21687
Modifications
UnsubscribeForceapi for consumer.Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation