Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] PIP-313 Add GetLastMessageIDs API #1221

Merged
merged 4 commits into from
May 28, 2024

Conversation

crossoverJie
Copy link
Member

Motivation

To keep consistent with the Java client.

Releted PR: apache/pulsar#20040

Modifications

  • Add GetLastMessageIDsapi for consumer.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (yes)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (GoDocs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@crossoverJie
Copy link
Member Author

@RobertIndie PTAL, thanks.

pulsar/consumer.go Outdated Show resolved Hide resolved
pulsar/message.go Outdated Show resolved Hide resolved
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. 👍
Left one comment for the test.

pulsar/consumer_multitopic_test.go Show resolved Hide resolved
@crossoverJie
Copy link
Member Author

@RobertIndie The integration test failed, maybe we can try it again, it passes in my own repository.

https://github.com/crossoverJie/pulsar-client-go/actions/runs/9253419225/job/25463657165

@RobertIndie RobertIndie merged commit 2d51323 into apache:master May 28, 2024
8 checks passed
@crossoverJie crossoverJie deleted the support-pip-224 branch May 29, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants