-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] PIP-313 Add GetLastMessageIDs API #1221
Conversation
@RobertIndie PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me. 👍
Left one comment for the test.
@RobertIndie The integration test failed, maybe we can try it again, it passes in my own repository. https://github.com/crossoverJie/pulsar-client-go/actions/runs/9253419225/job/25463657165 |
Motivation
To keep consistent with the Java client.
Releted PR: apache/pulsar#20040
Modifications
GetLastMessageIDs
api for consumer.Verifying this change
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation