Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] PIP-368: Support lookup based on the lookup properties #1303

Merged
merged 17 commits into from
Nov 1, 2024

Conversation

crossoverJie
Copy link
Member

@crossoverJie crossoverJie commented Oct 30, 2024

Motivation

Support pip: apache/pulsar#23223

Modifications

  • Upgrade Pulsar image to 4.0.0
  • Upgrade golint
  • Client support LookupProperties

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (yes)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (GoDocs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@BewareMyPower
Copy link
Contributor

Could you use a separated PR to fix conflicts after upgrading Pulsar to 4.0.0 like #1302?

BTW, I found the lint task in the Makefile is repeated, we use golangci/golangci-lint-action@v6 in CI, where make lint is never used.

@crossoverJie
Copy link
Member Author

BTW, I found the lint task in the Makefile is repeated, we use golangci/golangci-lint-action@v6 in CI, where make lint is never used.

You are right, make lint can be used locally.

@crossoverJie crossoverJie marked this pull request as ready for review October 31, 2024 08:02
@crossoverJie crossoverJie self-assigned this Oct 31, 2024
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use a separated PR to fix conflicts after upgrading Pulsar to 4.0.0?

In addition, we'd better use latest image by default.

@crossoverJie
Copy link
Member Author

Could you use a separated PR to fix conflicts after upgrading Pulsar to 4.0.0?

Sorry, I didn't fully understand what you meant😂.

This PR has upgraded the image to 4.0.0. do you mean to create a separate PR for this part? I think the contents of this PR are not complicated, and the code review should be completed quickly.

@BewareMyPower
Copy link
Contributor

This PR has upgraded the image to 4.0.0. do you mean to create a separate PR for this part?

Yes. Including the tool versions upgrade in a code PR is not a good practice.

@crossoverJie
Copy link
Member Author

crossoverJie commented Nov 1, 2024

Yes. Including the tool versions upgrade in a code PR is not a good practice.

PTAL @BewareMyPower . #1304

@BewareMyPower BewareMyPower added this to the v0.15.0 milestone Nov 1, 2024
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a test for verify the lookup properties in the pulsar/internal/lookup_service_test.go?

@crossoverJie
Copy link
Member Author

LGTM, could you add a test for verify the lookup properties in the pulsar/internal/lookup_service_test.go?

Relevant code has been added https://github.com/apache/pulsar-client-go/pull/1303/files#diff-eaa8996b10b63f4ccd290c3af5dff5397e3911ab7cd228e20ecc99f0d69aeff4.

@BewareMyPower BewareMyPower merged commit ccaf552 into apache:master Nov 1, 2024
7 checks passed
@crossoverJie crossoverJie deleted the support-pip-368 branch November 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants