Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pulsar to 3.3.2 #189

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Update Pulsar to 3.3.2 #189

merged 3 commits into from
Oct 16, 2024

Commits on Oct 7, 2024

  1. Update Pulsar to 3.3.2

    lhotari committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1dccd9f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    fb53ad9 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Replace order of given/willAnswer for spied objects

    The cause of the test hang was that the test was incorrectly setting up
    the spy on the type message builder impl. In previous Pulsar version of
    TypedMessageBuilderImpl, the fact that the method sendAsync was being
    called at mock setup time was not causing an issue. However, in the
    latest impl it did not like that and was throwing things off.
    
    Spied objects should always use the `doReturn|Answer|Throw()` family
    as described in https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/Mockito.html#important-gotcha-on-spying-real-objects--heading
    onobc committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    108d7ff View commit details
    Browse the repository at this point in the history