Update ToxiProxy and Pulsar images and adjust timeout intervals #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates the used images of ToxiProxy and Pulsar in tests from versions 2.7.0 and 3.1.3 to 2.9.0 and 3.2.3 respectively to keep up with the latest versions. Also, it introduces longer timeout intervals in the PulsarClientTests, changing them from 10 seconds to 2 hours for more reliable results. Finally, it improves task cancellation functionality in ConnectionPool for more robust error handling.
entvex
force-pushed
the
fix-pulsar-client-failing-tests
branch
from
5df09af
to
15eb3fe
Compare
|
I'll make another PR with a better description detailing the real problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two tests were failing using version 3.2.X of the Apache Pulsar Broker. Introducing longer timeout intervals in the tests, TokenSupplier_WhenTokenSupplierThrowsAnExceptionOnAuthChallenge_ShouldFaultProducer and TokenSupplier_WhenTokenSupplierReturnValidToken_ShouldStayConnected. Changing them from 10 seconds to 40 minutes for makes the tests work, nothing else changed.
Updates the used images of ToxiProxy and Pulsar in tests from versions 2.7.0 and 3.1.3 to 2.9.0 and 3.2.3 respectively to keep up with the latest versions.
Finally, I added a missing cancellation token in ConnectionPool.
Testing
All tests are green again