set template for ca issuer name and secret name + geo-replication installation example #565
Conversation
…tallation example
There was a problem hiding this comment.
Thanks for the PR, @gulecroc . Please remove the geo-replication changes out of this PR since that will simplify handling of this PR so that we first get the TLS templating changes made.
We can handle the geo-replication examples in a separate PR.
I really appreciate your effort in making a Geo-replication example available directly in the Pulsar helm chart.
One minor detail is that global Zookeeper isn't required in Pulsar to use geo-replication. For completeness of the examples, it would be useful to then have examples of both cases. The Pulsar documentation doesn't clearly explain the different ways Pulsar geo-replication can be configured.
| {{/* | ||
| Define the pulsar certs ca issuer name | ||
| */}} | ||
| {{- define "pulsar.certs.issuers.ca.name" -}} | ||
| {{- if .Values.certs.issuers.ca.name -}} | ||
| {{- .Values.certs.issuers.ca.name -}} | ||
| {{- else -}} | ||
| {{ template "pulsar.fullname" . }}-{{ .Values.certs.internal_issuer.component }}-ca-issuer | ||
| {{- end -}} | ||
| {{- end -}} | ||
|
|
||
| {{/* | ||
| Define the pulsar certs ca issuer secret name | ||
| */}} | ||
| {{- define "pulsar.certs.issuers.ca.secretName" -}} | ||
| {{- if .Values.certs.issuers.ca.secretName -}} | ||
| {{- .Values.certs.issuers.ca.secretName -}} | ||
| {{- else -}} | ||
| {{ printf "%s-%s" .Release.Name .Values.tls.ca_suffix }} | ||
| {{- end -}} | ||
| {{- end -}} |
There was a problem hiding this comment.
This is a great improvement.
One additional request would be to handle both .Values.certs.internal_issuer.type cases in these templates, for both "selfsigning" and "ca". That would make this PR more consistent. (#561 recently added/improved "ca" handling).
|
Hi @lhotari, I remove the geo-replication doc. |
Motivation
To test geo-replication, I would like to install the pulsar chart 3 times :
I also would like to use TLS. The global zookeeper install will create the CA issuer and certificate, and the 2 pulsar clusters will use it to create their certificates.
Modifications
Verifying this change