[fix][test] Add reconsumeLater call in RetryTopicTest#testRetryTopicWithMultiTopic. #23857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetumbled
added
area/test
and removed
doc-not-needed
thetumbled
changed the title
thetumbled
changed the title
nodece
approved these changes
Jan 17, 2025
thetumbled
changed the title
lhotari
approved these changes
Jan 17, 2025
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 31, 2025
…ithMultiTopic. (apache#23857) (cherry picked from commit 8015795) (cherry picked from commit 7c5d7a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
org.apache.pulsar.client.api.RetryTopicTest#testRetryTopicWithMultiTopicdon't test the behavior of retry topic at all.Instead of calling
reconsumeLaterto trigger redelivery, current test code trigger redelivery base on ack timeout.Modifications
Add reconsumeLater call to test the behavior of retry topic with multiple topics.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: