PROTON-2816/PROTON-2817: Support building python extension with unbun… #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dled proton There are 3 cases: * Bundled proton library - this should be the default and is what you should use with pip etc. * System proton library - this is what you should use in a distro package. * Use the in tree library built earlier in the build process - this is what you usually want for developer debugging, and should be the version actually tested by the in tree tests. This change also add control of the ability to package and test in isolated virtual python environments. Using these is the default, but under some circumstances you do not want the build process to construct a virtual environment by pulling packages from the internet. So we now have an option to turn this behaviour off and rely on the hosts python environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dled proton
There are 3 cases:
This change also add control of the ability to package and test in isolated virtual python environments. Using these is the default, but under some circumstances you do not want the build process to construct a virtual environment by pulling packages from the internet. So we now have an option to turn this behaviour off and rely on the hosts python environment.