Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #201] Fix (OOM) errors in Broker's pods when thet startup by accurately adhering to their allocated memory, rather than relying on the host's total memory. #210

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

MrLYG
Copy link
Contributor

@MrLYG MrLYG commented Jan 11, 2024

What is the purpose of the change

This update prevents Out-Of-Memory (OOM) errors in Broker's pods when they startup by accurately adhering to their allocated memory, rather than relying on the host's total memory.
For Fix [ISSUE #201].

Brief changelog

  • Resolved an issue in the Kubernetes setup where the 'free' command was used, leading to inaccurate memory allocations in pods.
  • Modified the system to make resource queries container-aware, specifically targeting memory and CPU resource limits.
  • Implemented changes to access cgroup data directly, ensuring precise readings of container-specific limits.
  • This update prevents Out-Of-Memory (OOM) errors in pods by accurately adhering to their allocated memory, rather than relying on the host's total memory.
  • Adjusted the startup scripts in apache-rocketmq-operator/images/broker/alpine/runbroker-customize.sh to reflect these improvements.
  • The changes contribute to the overall stability and efficiency of the Kubernetes environment, particularly in memory management.

Verifying this change

XXXX

Please go through this checklist to help us incorporate your contribution quickly and easily.

Notice: It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check RBAC rights for Kubernetes roles.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run make docker-build to build docker image for operator, try your changes from Pod inside your Kubernetes cluster, not just locally. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes.
  • Before committing your changes, remember to run make manifests to make sure the CRD files are updated.
  • Update documentation if necessary.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

This update prevents Out-Of-Memory (OOM) errors in  Broker's pods by accurately adhering to their allocated memory, rather than relying on the host's total memory.
@MrLYG
Copy link
Contributor Author

MrLYG commented Jan 11, 2024

fix #201

@caigy caigy merged commit e80e97f into apache:master Feb 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

free is the bad way to compute memory used by broker or nameservers in container.
2 participants