Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes documentation for building GraalVM Native Image #21341

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fixes documentation for building GraalVM Native Image #21341

merged 1 commit into from
Dec 2, 2022

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Oct 4, 2022 •
edited
Loading

Fixes #21051.

Changes proposed in this pull request:

  • Fixes documentation for building GraalVM Native Image.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have passed maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review October 4, 2022 14:03
@linghengqian linghengqian mentioned this pull request Oct 5, 2022
Closed
7 tasks
@linghengqian linghengqian changed the title Improve documentation for building Graal Native Image and fix Dockerfile errors Improve documentation for building Graal Native Image and use graalvm-ce-dev-builds Oct 6, 2022
@linghengqian linghengqian mentioned this pull request Oct 9, 2022
Closed
@linghengqian
Copy link
Member Author

  • @strongduanmu Hi, what improvements should I make to push this PR? I noticed that the 5.2.1 milestone has been emptied. 👀

@strongduanmu
Copy link
Member

@linghengqian We can still use the 5.2.1 milestone until we tag it tomorrow.

@strongduanmu
Copy link
Member

Besides, documentation does not need to specify milestones.

@linghengqian
Copy link
Member Author

@linghengqian linghengqian changed the title Improve documentation for building Graal Native Image and use graalvm-ce-dev-builds Fixes documentation for building GraalVM Native Image and release process Oct 24, 2022
@linghengqian linghengqian marked this pull request as draft October 24, 2022 06:24
@linghengqian
Copy link
Member Author

  • Sorry for being late. Because most of the GraalVM accessibility metadata that needs to be supplemented has nothing to do with ShardingSphere, it needs to be processed in Oracle's GraalVM accessibility metadata central repository. I prefer not to change the ShardingSphere Release document at this stage. I will update this PR soon.

@linghengqian linghengqian marked this pull request as ready for review November 14, 2022 08:22
@linghengqian linghengqian changed the title Fixes documentation for building GraalVM Native Image and release process Fixes documentation for building GraalVM Native Image Nov 14, 2022
@terrymanu terrymanu merged commit b097f4d into apache:master Dec 2, 2022
@linghengqian linghengqian deleted the graal-native-image branch December 2, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
in: document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build GraalVM Native Image nightly for ShardingSphere Proxy
3 participants
@linghengqian @strongduanmu @terrymanu