-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support readOnlyRootFilesystem #648
Conversation
I just pushed a commit that should fix the breaking tests. I've also experimented with the Solr container using |
I think so, i will test it on my side and give you feedback then. |
Sounds good, thanks @thomaswoeckinger ! |
From my point of view, at least some common request for collection creation, modification, deletion and sharding is working, so i think this is good to go |
Let's keep it just the zk-init container for now (or all the init containers we do). That way we don't break use cases we don't know about. Not sure there's a giant benefit for us to set it by default right now. |
Sounds good to me! Does this mean that this PR is good to merge, or should I change something? |
I added a changelog entry. Once the tests pass, I'll merge. Thanks for the great work! |
Awesome! Thanks for checking and merging! |
Add /tmp as emptyDir to zk-init and make it readOnlyRootFilesystem
Co-authored-by: Jason Gerlowski <[email protected]>
This should be the first part (or at least an initial attempt at it) for #624
It adds /tmp as emptyDir to the
zk-init
init container. It also setsreadOnlyRootFilesystem
to it. For testing and also why not 🙂 I've tested it with Solr 9.3 and a chroot and I see the chroot and I seereadOnlyRootFilesystem
in its container definition.Any feedback is welcome. Once we agree about this, I'd like to check if Solr itself can run as
readOnlyRootFilesystem
and if not, add support for that, check for issues and iron them out.