Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16295: Modernize helm-chart project description #721

Merged
merged 6 commits into from
Sep 6, 2024
Merged

SOLR-16295: Modernize helm-chart project description #721

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ad7005
Modernize helm-chart project description
gerlowskija Sep 3, 2024
0af596e
Review feedback, rd 1
gerlowskija Sep 5, 2024
ba85918
Address review feedback, rd 2
gerlowskija Sep 5, 2024
f329ea2
Address review comments, rd 3
gerlowskija Sep 5, 2024
7bdf23b
Revert "Address review comments, rd 3"
gerlowskija Sep 6, 2024
aeba762
Fix missing punctuation
gerlowskija Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions helm/solr/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
Apache Solr
=============

Apache Solr is the popular, blazing-fast, open source enterprise search platform built on Apache Lucene™.

Solr is highly reliable, scalable and fault tolerant, providing distributed indexing, replication and load-balanced querying, automated failover and recovery, centralized configuration and more.
Solr powers the search and navigation features of many of the world's largest internet sites.
Solr is the blazing fast, open source, multi-modal search platform built on Apache Lucene. Its full-text, vector, and geospatial search power many of the world's largest organizations.
Major features include: Kubernetes and docker integration; streaming and analytics; and highlighting, faceting, and spellchecking.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second sentence starts with "Major features" yet the first sentence listed some. Perhaps the first should list broad categories and thus shouldn't include geospatial (leave for 2nd). Should list analytics up there.

Copy link
Contributor Author

@gerlowskija gerlowskija Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my mind at least, there's a distinction between the lists in each sentence. The first sentence (and its list) is focused narrowly on the "types" of search that Solr supports: full-text, vector, etc. The second sentence is a more general grab-bag, to list things users might care about that aren't strictly search-related.

Given that distinction - I guess i could imagine putting "analytics" (or "analytics search") in the first sentence if you feel strongly about it? But I probably wouldn't move "geospatial" to the second sentence, unless we want to ditch my distinction altogether.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand you (I might not!), you seem to want the first sentence to be scoped to search. Why constrain that; why not analytics? Arguably vector is an area separate from full-text as well (and I'm glad you list it in the first sentence).

Copy link
Contributor Author

@gerlowskija gerlowskija Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand you (I might not!), you seem to want the first sentence to be scoped to search.

I do, yep. In the first sentence I'm trying to highlight the different types of search we support. "Full-text search", "geospatial search", and "vector search" all seemed to fit.

"Analytics" IMO is a little more borderline - I don't often hear people talk about "analytics search" the same way I hear some of those other terms. But as I said above, I'm happy to swap things around given your feedback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, updated. I've also made similar tweaks to the "main repo" PR here, where necessary.


Documentation around using Apache Solr can be found on it's [official site](https://solr.apache.org).

Expand Down
Loading