[SPARK-50531][SQL] Update StringType proto to support constraints
#49130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailom-db
approved these changes
Dec 16, 2024
Resolve conflicts
MJovan2002
force-pushed
the
char_varchar_proto
branch
from
3ea0386 to
d63cfc8
Compare
HyukjinKwon
approved these changes
Jan 28, 2025
|
@MJovan2002 could you please sync with master again, so we can merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding support for
StringTypeconstraints to proto.Why are the changes needed?
This PR would allow us to fully serialize Char/Varchar types through StringType and is a part of the effort to improve char/varchar support.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.
Note for anyone using
dev/gen-protos.shMake sure you run
pip install -r dev/requirements.txtbefore running this script. Also make sure to have python in yourPATH.