[SPARK-50770][SS] Removing package scope for transformWithState operator APIs #49417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericm-db
changed the title
HyukjinKwon
reviewed
Jan 9, 2025
sql/api/src/main/scala/org/apache/spark/sql/streaming/ExpiredTimerInfo.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
changed the title
|
Gentle ping, @ericm-db . Please address the above review comments. |
sql/api/src/main/scala/org/apache/spark/sql/streaming/ExpiredTimerInfo.scala
Show resolved
Hide resolved
|
NOTE: PLEASE DO NOT MERGE THIS PR. WE HAVE TO ADDRESS SPARK CONNECT WHICH WILL BE COMING SOON. |
|
@ericm-db Could you please change the title to add |
HeartSaVioR
requested changes
Jan 16, 2025
ericm-db
changed the title
We discussed this offline and we are not going to treat connect work as a blocker for 4.0. We have the Scala PR for connect support in review - #49488 and we will work on the Python PR too. But we will treat them as best effort for 4.0. |
ericm-db
changed the title
anishshri-db
approved these changes
Jan 18, 2025
|
@HeartSaVioR - PTAL when u get a chance, thx ! |
HeartSaVioR
approved these changes
Jan 23, 2025
|
@HeartSaVioR - CI is green. Not updating above. Just fyi |
|
Thanks! Merging to master/4.0. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Jan 24, 2025
…tor APIs ### What changes were proposed in this pull request? Removing package scope for transformWithState operator APIs This enables us to release the transformWithState APIs from the next Spark release. While traits and methods expand visibility, the usage is blocked due to a flag. The flag will be flipped in separate PR and corresponding behavior change ticket will be filed with it. ### Why are the changes needed? To allow use of the transformWithState operator ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Existing unit tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #49417 from ericm-db/enable-tws. Authored-by: Eric Marnadi <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]> (cherry picked from commit be77e1e) Signed-off-by: Jungtaek Lim <[email protected]>
|
Thank you all for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removing package scope for transformWithState operator APIs
This enables us to release the transformWithState APIs from the next Spark release. While traits and methods expand visibility, the usage is blocked due to a flag. The flag will be flipped in separate PR and corresponding behavior change ticket will be filed with it.
Why are the changes needed?
To allow use of the transformWithState operator
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Existing unit tests
Was this patch authored or co-authored using generative AI tooling?
No