[SPARK-50947][PYTHON][SQL][CONNECT] Assign appropriate error class and SparkException for duplicated artifacts #49598
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licated artifacts
|
Also cc @MaxGekk fyi |
itholic
changed the title
MaxGekk
reviewed
Jan 22, 2025
MaxGekk
approved these changes
Jan 23, 2025
|
The test failure is not related to the changes: |
|
+1, LGTM. Merging to master/4.0. |
MaxGekk
pushed a commit
that referenced
this pull request
Jan 23, 2025
…d SparkException for duplicated artifacts ### What changes were proposed in this pull request? This PR proposes to assign appropriate error class and SparkException for duplicated artifacts. ### Why are the changes needed? To convert SparkConnectGrpcException into proper PySparkException so that we can ensure handling exceptions from Spark Connect Server properly. ### Does this PR introduce _any_ user-facing change? No API changes, but the user-facing error message would be improved. ### How was this patch tested? Updated the existing test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49598 from itholic/duplicated_artifact. Authored-by: Haejoon Lee <[email protected]> Signed-off-by: Max Gekk <[email protected]> (cherry picked from commit 6e4240f) Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to assign appropriate error class and SparkException for duplicated artifacts.
Why are the changes needed?
To convert SparkConnectGrpcException into proper PySparkException so that we can ensure handling exceptions from Spark Connect Server properly.
Does this PR introduce any user-facing change?
No API changes, but the user-facing error message would be improved.
How was this patch tested?
Updated the existing test.
Was this patch authored or co-authored using generative AI tooling?
No.