[SPARK-50959][ML][PYTHON] Swallow the exception of JavaWrapper.__del__ #49615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HyukjinKwon , @zhengruifeng @WeichenXu123 , please help review it. Thx a lot. |
HyukjinKwon
changed the title
zhengruifeng
approved these changes
Jan 23, 2025
zhengruifeng
pushed a commit
that referenced
this pull request
Jan 23, 2025
### What changes were proposed in this pull request?
``` python
from pyspark.ml.classification import LogisticRegression
from pyspark.ml.linalg import Vectors
from pyspark.sql import SparkSession
spark = SparkSession.builder.master("local[*]").getOrCreate()
dataset = spark.createDataFrame(
[(Vectors.dense([0.0]), 0.0),
(Vectors.dense([0.4]), 1.0),
(Vectors.dense([0.5]), 0.0),
(Vectors.dense([0.6]), 1.0),
(Vectors.dense([1.0]), 1.0)] * 10,
["features", "label"])
lr = LogisticRegression()
model = lr.fit(dataset)
```
The above code will raise exception at the end. Even I remove the `try_remote_del` from https://github.com/apache/spark/blob/master/python/pyspark/ml/wrapper.py#L58 , the issue is still there.
``` console
Exception ignored in: <function JavaWrapper.del_ at 0x70b8caf2f920>_
Traceback (most recent call last):
File "/home/xxx/work.d/spark/spark-master/python/pyspark/ml/util.py", line 254, in wrapped
File "/home/xxx/work.d/spark/spark-master/python/pyspark/ml/wrapper.py", line 60, in __del__
ImportError: sys.meta_path is None, Python is likely shutting down
Exception ignored in: <function JavaWrapper.del_ at 0x70b8caf2f920>_
Traceback (most recent call last):
File "/home/xxx/work.d/spark/spark-master/python/pyspark/ml/util.py", line 254, in wrapped
File "/home/xxx/work.d/spark/spark-master/python/pyspark/ml/wrapper.py", line 60, in __del__
ImportError: sys.meta_path is None, Python is likely shutting down
```
Looks like the `__del__` function of JavaWrapper is called after python shutting down and the python related modules is not functional.
### Why are the changes needed?
Fix the bug, good user experience.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI passes
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #49615 from wbo4958/del.bug.
Authored-by: Bobby Wang <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
(cherry picked from commit 74cf4d8)
Signed-off-by: Ruifeng Zheng <[email protected]>
|
merged to master/4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The above code will raise exception at the end. Even I remove the
@try_remote_delfrom https://github.com/apache/spark/blob/master/python/pyspark/ml/wrapper.py#L58 , the issue is still there.Looks like the
__del__function of JavaWrapper is called after python shutting down and the python related modules is not functional.Why are the changes needed?
Fix the bug, good user experience.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passes
Was this patch authored or co-authored using generative AI tooling?
No