[SPARK-50967][SS] Add option to skip emitting initial state keys within the FMGWS operator #49632
+197
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he FMGWS operator
anishshri-db
changed the title
|
cc - @HeartSaVioR - PTAL, thx ! |
HeartSaVioR
reviewed
Jan 31, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala
Outdated
Show resolved
Hide resolved
|
Thanks! Merging to master/4.0. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Feb 1, 2025
…in the FMGWS operator ### What changes were proposed in this pull request? Add option to skip emitting initial state keys within the FMGWS operator ### Why are the changes needed? Without this change, user does not have an easy way of filtering initial state rows emitted as part of the first batch. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added unit tests ``` [info] Run completed in 15 seconds, 349 milliseconds. [info] Total number of tests run: 4 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 51 s, completed Jan 23, 2025, 4:26:03 PM ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes #49632 from anishshri-db/task/SPARK-50967-fix. Authored-by: Anish Shrigondekar <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]> (cherry picked from commit cfc3f1f) Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add option to skip emitting initial state keys within the FMGWS operator
Why are the changes needed?
Without this change, user does not have an easy way of filtering initial state rows emitted as part of the first batch.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit tests
Was this patch authored or co-authored using generative AI tooling?
No