[SPARK-50908][SS][PYTHON] Disable flaky TTL test in test_pandas_transform_with_state.py
#49634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jan 24, 2025
|
Okay we can skip it for now |
|
Merged to master and branch-4.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 24, 2025
…sform_with_state.py` Disable the flaky TTL suite for TransformWithStateInPandas. The suite is flaky on CI because for this test case, we want to test on scenarios of one key expires and the other key is still in the state store. The tricky thing is that we don't have equivalent of `StreamManualClock` in Scala and we have to manually set a Thread.sleep() time duration such that the TTL expires after a certain time duration while the other key does not. As the batch duration varies a lot on CI, this suite is flaky. We decided to disable the suite until we find a holistic fix. No. Tested on CI. No. Closes #49634 from jingz-db/fix-ttl-suite. Authored-by: jingz-db <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 8f66aef) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable the flaky TTL suite for TransformWithStateInPandas.
Why are the changes needed?
The suite is flaky on CI because for this test case, we want to test on scenarios of one key expires and the other key is still in the state store. The tricky thing is that we don't have equivalent of
StreamManualClockin Scala and we have to manually set a Thread.sleep() time duration such that the TTL expires after a certain time duration while the other key does not. As the batch duration varies a lot on CI, this suite is flaky. We decided to disable the suite until we find a holistic fix.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested on CI.
Was this patch authored or co-authored using generative AI tooling?
No.