Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50970][PYTHON][SS] Unify naming convention for stateful processor APIs #49636

Closed
wants to merge 2 commits into from

Conversation

bogao007
Copy link
Contributor

@bogao007 bogao007 commented Jan 24, 2025

What changes were proposed in this pull request?

Unify naming convention for stateful processor APIs.

Why are the changes needed?

Following best practice, make TransformWithStateInPandas naming convention consistent across APIs.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Existing unit test.

Was this patch authored or co-authored using generative AI tooling?

No.

@HeartSaVioR
Copy link
Contributor

https://github.com/bogao007/spark/actions/runs/12942132674/job/36099374376
It seems to be failing on linter.

Copy link
Contributor

@anishshri-db anishshri-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending green CI

@HeartSaVioR
Copy link
Contributor

https://github.com/bogao007/spark/runs/36104154381
Looks like CI is passed.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@HeartSaVioR
Copy link
Contributor

Thanks! Merging to master/4.0.

HeartSaVioR pushed a commit that referenced this pull request Jan 24, 2025
…sor APIs

### What changes were proposed in this pull request?

Unify naming convention for stateful processor APIs.

### Why are the changes needed?

Following best practice, make TransformWithStateInPandas naming convention consistent across APIs.

### Does this PR introduce _any_ user-facing change?

Yes.

### How was this patch tested?

Existing unit test.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49636 from bogao007/python-tws-syntax.

Authored-by: bogao007 <[email protected]>
Signed-off-by: Jungtaek Lim <[email protected]>
(cherry picked from commit c662441)
Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants