Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50974][ML][PYTHON][CONNECT] Add support foldCol for CrossValidator on connect #49743

Closed
wants to merge 2 commits into from

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Jan 31, 2025

What changes were proposed in this pull request?

This PR adds support foldCol for CrossValidator on connect

Why are the changes needed?

feature parity

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

The CI passes

Was this patch authored or co-authored using generative AI tooling?

No

@wbo4958 wbo4958 marked this pull request as ready for review January 31, 2025 05:24
@wbo4958
Copy link
Contributor Author

wbo4958 commented Jan 31, 2025

Hey @zhengruifeng, Could you help review this PR, thx very much.

zhengruifeng pushed a commit that referenced this pull request Feb 2, 2025
…ator on connect

### What changes were proposed in this pull request?

This PR adds support foldCol for CrossValidator on connect

### Why are the changes needed?
feature parity

### Does this PR introduce _any_ user-facing change?
Yes

### How was this patch tested?
The CI passes

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #49743 from wbo4958/cv-fold.

Authored-by: Bobby Wang <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
(cherry picked from commit 736752e)
Signed-off-by: Ruifeng Zheng <[email protected]>
@zhengruifeng
Copy link
Contributor

thanks, merged to master/4.0

@wbo4958 wbo4958 deleted the cv-fold branch February 2, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants