Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51047][SS][TESTS] Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals #49747

Closed
wants to merge 2 commits into from

Conversation

anishshri-db
Copy link
Contributor

@anishshri-db anishshri-db commented Jan 31, 2025

What changes were proposed in this pull request?

Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals

Why are the changes needed?

Improve coverage in this area

Does this PR introduce any user-facing change?

No

How was this patch tested?

Test only change

[info] Run completed in 8 minutes, 33 seconds.
[info] Total number of tests run: 1032
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1032, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

Was this patch authored or co-authored using generative AI tooling?

No

@anishshri-db anishshri-db changed the title [SPARK-51047] Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals [SPARK-51047][SS] Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals Jan 31, 2025
@anishshri-db
Copy link
Contributor Author

cc - @HeartSaVioR - PTAL, thx !

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in overall. Only nits.

@HeartSaVioR HeartSaVioR changed the title [SPARK-51047][SS] Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals [SPARK-51047][SS][TESTS] Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals Feb 1, 2025
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@HeartSaVioR
Copy link
Contributor

Thanks! Merging to master/4.0.

HeartSaVioR pushed a commit that referenced this pull request Feb 1, 2025
…ro start ordinals as well as non-ascending ordinals

### What changes were proposed in this pull request?
Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals

### Why are the changes needed?
Improve coverage in this area

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Test only change

```
[info] Run completed in 8 minutes, 33 seconds.
[info] Total number of tests run: 1032
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1032, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
```

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #49747 from anishshri-db/task/SPARK-51047.

Authored-by: Anish Shrigondekar <[email protected]>
Signed-off-by: Jungtaek Lim <[email protected]>
(cherry picked from commit 5cd25fc)
Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants