[SPARK-51050] [SQL] Add group by alias tests to the group-by.sql #49750
+222
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +78,10 @@ set spark.sql.groupByAliases=false; | |||
|
|
|||
| -- Check analysis exceptions | |||
| SELECT a AS k, COUNT(b) FROM testData GROUP BY k; | |||
| SELECT 1 GROUP BY `1`; | |||
There was a problem hiding this comment.
Idea was to add some tests that should fail (with set spark.sql.groupByAliases=false;). I can remove them if needed
| SELECT 1 AS a FROM testData GROUP BY `a`; | ||
|
|
||
| -- GROUP BY implicit alias | ||
| SELECT 1 GROUP BY `1`; |
There was a problem hiding this comment.
Suggested change
| SELECT 1 GROUP BY `1`; | |
| SELECT 1 GROUP BY `1`; | |
| -- GROUP BY alias with the subquery name | |
| SELECT (SELECT a FROM testData LIMIT 1) + (SELECT b FROM testData LIMIT 1) FROM VALUES (1, 2) GROUP BY `(SELECTaFROMtestDataLIMIT1)+(SELECTbFROMtestDataLIMIT1)` | |
| -- GROUP BY with expression subqueries | |
| SELECT a, count(*) FROM testData GROUP BY (SELECT b FROM testData) | |
| SELECT a, count(*) FROM testData GROUP BY a, (SELECT b FROM testData) | |
| SELECT a, count(*) FROM testData GROUP BY a, (SELECT b FROM testData LIMIT 1) | |
| SELECT a, count(*) FROM testData GROUP BY a, b IN (SELECT a FROM testData) | |
| SELECT a, count(*) FROM testData GROUP BY a, a IN (SELECT b FROM testData) | |
| SELECT a, count(*) FROM testData GROUP BY a, EXISTS(SELECT b FROM testData) |
| -- !query analysis | ||
| org.apache.spark.sql.catalyst.ExtendedAnalysisException | ||
| { | ||
| "errorClass" : "UNRESOLVED_COLUMN.WITHOUT_SUGGESTION", |
There was a problem hiding this comment.
Idea was to add some tests that should fail (with set spark.sql.groupByAliases=false;). I can remove them if needed
|
Why you add these test cases here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I propose that we extend group-by.sql with some cases where we
group byaliases.Why are the changes needed?
Extend the testing coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests.
Was this patch authored or co-authored using generative AI tooling?
No.