fix(#2997): Fix default selection for timestamp rule (#2998)

apache · Jul 5, 2024 · 6136d93 · 6136d93
1 parent a6e5958
commit 6136d93
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 28 deletions.
diff --git a/ui/cypress/tests/adapter/fileStream.smoke.spec.ts b/ui/cypress/tests/adapter/fileStream.smoke.spec.ts
@@ -85,24 +85,26 @@ describe(
             );
         });
 
-        // it('File Stream adapter with unix timestamp in milliseconds', () => {
-        //     FileManagementUtils.addFile('connect/fileReplay/timestampInMilliseconds/input.csv');
-        //     const adapterConfiguration =
-        //         ConnectUtils.setUpPreprocessingRuleTest(false);
-        //
-        //     // Edit timestamp property
-        //     ConnectEventSchemaUtils.editTimestampPropertyWithNumber(
-        //         'timestamp',
-        //         'Milliseconds',
-        //     );
-        //
-        //     ConnectEventSchemaUtils.finishEventSchemaConfiguration();
-        //     ConnectUtils.tearDownPreprocessingRuleTest(
-        //         adapterConfiguration,
-        //         'cypress/fixtures/connect/fileReplay/timestampInMilliseconds/expected.csv',
-        //         false,
-        //         2000,
-        //     );
-        // });
+        it('File Stream adapter with unix timestamp in milliseconds', () => {
+            FileManagementUtils.addFile(
+                'connect/fileReplay/timestampInMilliseconds/input.csv',
+            );
+            const adapterConfiguration =
+                ConnectUtils.setUpPreprocessingRuleTest(false);
+
+            // Edit timestamp property
+            ConnectEventSchemaUtils.editTimestampPropertyWithNumber(
+                'timestamp',
+                'Milliseconds',
+            );
+
+            ConnectEventSchemaUtils.finishEventSchemaConfiguration();
+            ConnectUtils.tearDownPreprocessingRuleTest(
+                adapterConfiguration,
+                'cypress/fixtures/connect/fileReplay/timestampInMilliseconds/expected.csv',
+                false,
+                2000,
+            );
+        });
     },
 );
diff --git a/.../edit-value-transformation/edit-timestamp-property/edit-timestamp-property.component.html b/.../edit-value-transformation/edit-timestamp-property/edit-timestamp-property.component.html
@@ -64,7 +64,7 @@
                     Milliseconds
                 </mat-option>
                 <mat-option
-                    value="second"
+                    value="seconds"
                     (click)="
                         cachedProperty.additionalMetadata.multiplier = 1000
                     "

diff --git a/...ts/edit-value-transformation/edit-timestamp-property/edit-timestamp-property.component.ts b/...ts/edit-value-transformation/edit-timestamp-property/edit-timestamp-property.component.ts
@@ -16,21 +16,25 @@
  *
  */
 
-import { Component, Input } from '@angular/core';
+import { Component, Input, OnInit } from '@angular/core';
 
 @Component({
     selector: 'sp-edit-timestamp-property',
     templateUrl: './edit-timestamp-property.component.html',
     styleUrls: ['./edit-timestamp-property.component.scss'],
 })
-export class EditTimestampPropertyComponent {
-    @Input() cachedProperty: any;
-    @Input() showEditTimestampProperty: boolean;
+export class EditTimestampPropertyComponent implements OnInit {
+    @Input()
+    cachedProperty: any;
+    @Input()
+    showEditTimestampProperty: boolean;
 
-    private selectedTimeMultiplier;
+    selectedTimeMultiplier = 'seconds';
 
-    constructor() {
-        // Set preselected value
-        this.selectedTimeMultiplier = 'second';
+    ngOnInit(): void {
+        // Change default if multiplier is 1
+        if (this.cachedProperty.additionalMetadata.multiplier == 0) {
+            this.selectedTimeMultiplier = 'milliseconds';
+        }
     }
 }